Repository navigation
test: open stores saved by v1.4 and v1.5 with today's schema - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app opens its store with
try!(NormalApp.swift), so a store that can't migrate crashes on every launch. No test opens a store in an older release's format:UsageLimit.Change
StoreUpgradeTestsholds frozen copies of the v1.4 and v1.5 models: stored properties, enum raw values, and a key salt and hash computed outside the app. Each test writes a store with the old models and reopens it with the app's schema.NormalApp.modelsis the one model list. The app and every test container use it, replacing 5 copies in the tests.No behavior change.
Tests
SettingsfieldhideDonateButtonrenamed withoutoriginalName